Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(usb): Set default HID interval to 1ms (1000Hz) #1271

Merged
merged 1 commit into from Apr 30, 2022
Merged

feat(usb): Set default HID interval to 1ms (1000Hz) #1271

merged 1 commit into from Apr 30, 2022

Conversation

Nicell
Copy link
Member

@Nicell Nicell commented Apr 26, 2022

No description provided.

@Nicell Nicell added enhancement New feature or request usb hid labels Apr 26, 2022
joelspadin
joelspadin approved these changes Apr 30, 2022
View reviewed changes
Copy link
Collaborator

@joelspadin joelspadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since most boards should be able to support this, I think it makes sense to set it by default, and then it can be overridden for just boards that don't support it. Looks good to me.

petejohanson
petejohanson approved these changes Apr 30, 2022
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked swimmingly on my stm32f072 BDN9 V2, so good by me.

@petejohanson petejohanson merged commit d33b355 into zmkfirmware:main Apr 30, 2022
@Nicell Nicell deleted the usb/poll-interval branch April 30, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petejohanson petejohanson petejohanson approved these changes

@joelspadin joelspadin joelspadin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hid usb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nicell @petejohanson @joelspadin