feat(drivers): Driver for MAX7318 GPIO expander #1295

zhiayang · 2022-05-10T06:32:48Z

Adds a driver for the MAX7318 16-port I2C GPIO expander. Doesn't support the interrupt feature (yet?).

Has been tested on real hardware.

I've moved the existing mcp23017 driver to its own subfolder as well to keep things a little more organised.

petejohanson

Thanks for working on this!

I don't really agree w/ the need for separate dirs yet for this, IMHO, can you please not mix that in w/ the new driver here?

Other than that, a few suggestions, I imagine mostly stemming from you copying our current out of tree driver that's missing some upstream QOL improvements.

petejohanson · 2022-06-04T02:46:48Z

app/drivers/gpio/max7318/Kconfig

+menuconfig GPIO_MAX7318
+	bool "MAX7318 I2C-based GPIO chip"
+	depends on I2C
+	select HAS_DTS_GPIO


See the 595 gpio driver I just merged for an example of how to auto-enable this if found in the DT.

yep, copied it over.

petejohanson · 2022-06-04T02:50:56Z

app/drivers/gpio/max7318/gpio_max7318.c

+
+#define MAX7318_INIT(inst)                                                                         \
+    static struct max7318_config max7318_##inst##_config = {                                       \
+        .i2c_dev_name = DT_INST_BUS_LABEL(inst),                                                   \


The common stuff should be initialized here, see https://github.com/zmkfirmware/zmk/blob/main/app/drivers/gpio/gpio_595.c#L200 for an example.

Also, Zephyr has newer APIs for the bus stuff, which isn't incorporated into our local mcp23017 driver yet, but should be used for newer drivers. The I2C idea can be seen at https://github.com/zmkfirmware/zmk/blob/main/app/drivers/gpio/gpio_595.c#L205 but there is an equivalent macro and API for SPI.

I think you meant s/spi/i2c/. I hope I made the changes correctly (it compiles); will test with my board to make sure it works when I get the time (soon)

petejohanson · 2022-06-04T02:53:22Z

app/drivers/gpio/max7318/gpio_max7318.c

+    uint16_t data = sys_cpu_to_le16(value);
+    uint16_t dev_addr = ((struct max7318_config *)dev->config)->device_addr;
+
+    return i2c_burst_write(drv_data->i2c, dev_addr, reg, (uint8_t *)&data, sizeof(data));


Move to the _dt version of this.

petejohanson · 2022-06-04T02:53:40Z

app/drivers/gpio/max7318/gpio_max7318.c

+    uint16_t dev_addr = ((struct max7318_config *)dev->config)->device_addr;
+
+    uint16_t data = 0;
+    int ret = i2c_burst_read(drv_data->i2c, dev_addr, reg, (uint8_t *)&data, sizeof(data));


Ditto, move to the _dt version of this.

zhiayang · 2022-06-04T09:21:10Z

Addressed the PR comments

zhiayang · 2022-08-19T09:37:33Z

@petejohanson are there any more issues preventing this from being merged? let me know what else to change. thanks!

petejohanson

Just one minor nitpick, probably keeping this from automatically being enabled if the DTS contains a compatible node.

petejohanson · 2022-09-26T03:50:32Z

app/drivers/gpio/Kconfig.max7318

+# Copyright (c) 2022 The ZMK Contributors
+# SPDX-License-Identifier: MIT
+
+DT_COMPAT_ZMK_GPIO_MAX7318 := zmk,gpio-max7318


This doesn't match the compatible defined in the yaml binding or used in the code. Accident or intentional?

Ah, my bad. The MCP23017 driver doesn't have gpio- in front, but the 595 does -- which one should I follow here?

Thanks!

Follow the mcp format is fine.

zhiayang · 2022-09-27T12:58:44Z

should've fixed them now!

petejohanson

Just one other nitpick for the naming changes.

app/drivers/gpio/Kconfig.max7318

Co-authored-by: Pete Johanson <peter@peterjohanson.com>

zhiayang · 2022-09-29T17:24:19Z

done!

petejohanson

Thanks!

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

zhiayang added 2 commits May 10, 2022 13:45

refactor(drivers): move mcp23017 expander driver into its own folder

9ad25bf

feat(drivers): add driver for max7318 i2c gpio expander

1bba090

petejohanson requested changes Jun 4, 2022

View reviewed changes

zhiayang added 5 commits June 4, 2022 16:38

revert moving the mcp23017 driver into its own folder

bda838e

move max7318 driver out of the folder too

4a368a6

Merge remote-tracking branch 'upstream/main' into gpio-driver-max7318

012031c

use dt_compat setup for max7318 kconfig

f7e2b29

use _dt functions for reading/writing

ce866bd

zhiayang mentioned this pull request Jun 4, 2022

feat(drivers): add driver for MAX17048 fuel gauge #1301

Merged

zhiayang requested a review from petejohanson June 4, 2022 09:21

zhiayang added 2 commits June 6, 2022 21:42

Merge remote-tracking branch 'upstream/main' into gpio-driver-max7318

a616d0d

add gpio build fix from zmkfirmware#1335

ad4959f

caksoylar added enhancement New feature or request core Core functionality/behavior of ZMK labels Jul 4, 2022

Merge remote-tracking branch 'upstream/main' into gpio-driver-max7318

4d48189

petejohanson reviewed Sep 26, 2022

View reviewed changes

zhiayang added 2 commits September 27, 2022 20:56

update to address PR

52ae168

Update Kconfig.max7318

7bb5d15

petejohanson requested changes Sep 28, 2022

View reviewed changes

app/drivers/gpio/Kconfig.max7318 Outdated Show resolved Hide resolved

app/drivers/gpio/Kconfig.max7318 Outdated Show resolved Hide resolved

zhiayang and others added 2 commits September 28, 2022 14:25

Update app/drivers/gpio/Kconfig.max7318

50e82fe

Co-authored-by: Pete Johanson <peter@peterjohanson.com>

Update app/drivers/gpio/Kconfig.max7318

3ec383c

Co-authored-by: Pete Johanson <peter@peterjohanson.com>

petejohanson approved these changes Sep 30, 2022

View reviewed changes

petejohanson merged commit cc3d552 into zmkfirmware:main Sep 30, 2022

alinelena pushed a commit to alinelena/zmk that referenced this pull request Sep 30, 2022

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

db5725b

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

alinelena pushed a commit to alinelena/zmk that referenced this pull request Sep 30, 2022

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

0520ee4

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

alinelena pushed a commit to alinelena/zmk that referenced this pull request Sep 30, 2022

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

0006b6a

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

tyalie pushed a commit to tyalie/zmk that referenced this pull request Nov 15, 2022

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

fc389cc

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

zhiayang deleted the gpio-driver-max7318 branch December 21, 2022 08:40

zhiayang added a commit to zhiayang/zmk that referenced this pull request Dec 21, 2022

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

38b17cb

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

rafaelromao pushed a commit to rafaelromao/zmk that referenced this pull request Dec 22, 2022

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

1ece840

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

rafaelromao pushed a commit to rafaelromao/zmk that referenced this pull request Dec 23, 2022

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

144428c

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

abondis pushed a commit to abondis/zmk that referenced this pull request Feb 12, 2023

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

f96905b

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

abondis pushed a commit to abondis/zmk that referenced this pull request Feb 12, 2023

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

947bea1

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

abondis pushed a commit to abondis/zmk that referenced this pull request Feb 14, 2023

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

e4c6b5b

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

NikolaRavic pushed a commit to NikolaRavic/zmk-firmware that referenced this pull request Feb 27, 2023

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

5081e12

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

Lugoues pushed a commit to Lugoues/zmk that referenced this pull request Mar 9, 2023

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

8d12b82

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

nickconway pushed a commit to nickconway/zmk that referenced this pull request Jun 2, 2023

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

89daf8f

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

yuanbin pushed a commit to yuanbin/zmk that referenced this pull request Jun 14, 2023

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

281d108

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

FearlessSpiff pushed a commit to FearlessSpiff/zmk that referenced this pull request Oct 31, 2023

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

0c92755

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

FearlessSpiff pushed a commit to FearlessSpiff/zmk that referenced this pull request Oct 31, 2023

feat(drivers): Driver for MAX7318 GPIO expander (zmkfirmware#1295)

dde4f5c

Add driver for max7318 i2c gpio expander Co-authored-by: Pete Johanson <peter@peterjohanson.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(drivers): Driver for MAX7318 GPIO expander #1295

feat(drivers): Driver for MAX7318 GPIO expander #1295

zhiayang commented May 10, 2022 •

edited

petejohanson left a comment

petejohanson Jun 4, 2022

zhiayang Jun 4, 2022

petejohanson Jun 4, 2022

zhiayang Jun 4, 2022

petejohanson Jun 4, 2022

zhiayang Jun 4, 2022

petejohanson Jun 4, 2022

zhiayang Jun 4, 2022

zhiayang commented Jun 4, 2022

zhiayang commented Aug 19, 2022

petejohanson left a comment

petejohanson Sep 26, 2022

zhiayang Sep 26, 2022

petejohanson Sep 26, 2022

zhiayang commented Sep 27, 2022

petejohanson left a comment

zhiayang commented Sep 29, 2022

petejohanson left a comment

feat(drivers): Driver for MAX7318 GPIO expander #1295

feat(drivers): Driver for MAX7318 GPIO expander #1295

Conversation

zhiayang commented May 10, 2022 • edited

petejohanson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhiayang commented Jun 4, 2022

zhiayang commented Aug 19, 2022

petejohanson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhiayang commented Sep 27, 2022

petejohanson left a comment

Choose a reason for hiding this comment

zhiayang commented Sep 29, 2022

petejohanson left a comment

Choose a reason for hiding this comment

zhiayang commented May 10, 2022 •

edited