feat(kscan): Add toggle-mode to updated direct-wire kscan #1305
Conversation
Co-authored-by: Pete Johanson <peter@peterjohanson.com>
- Fix logic in getting pulls from ACTIVE_LOW vs. ACTIVE_HIGH DT flags - Add pulls on init
kurtis-lew
force-pushed
the
toggleswitch_2.0_PR
branch
from
d59797a
to
0ec0087
Compare
kurtis-lew
force-pushed
the
toggleswitch_2.0_PR
branch
from
7278054
to
37e9049
Compare
kurtis-lew
force-pushed
the
toggleswitch_2.0_PR
branch
2 times, most recently
from
dcab9a3
to
24affa0
Compare
kurtis-lew
force-pushed
the
toggleswitch_2.0_PR
branch
from
24affa0
to
7bb3a2f
Compare
| @@ -124,6 +125,32 @@ static void kscan_direct_irq_callback_handler(const struct device *port, struct | |||
| } | |||
| #endif | |||
|
|
|||
| static gpio_flags_t kscan_gpio_get_extra_flags(const struct gpio_dt_spec *gpio, bool active) { | |||
| gpio_flags_t flags = BIT(0) & gpio->dt_flags; | |||
There was a problem hiding this comment.
I don't think we need to return the first bit here at all, since that will be set in the DT still. We need to check it, but not include in the "extra" flags we'll use.
Minor thing, but in case we end up using this some other way later, good to really only just return the extra flags we need, not also include the active bit.
👷 Deploy request for zmk accepted.
|
|
The docs on this aren't quite clear to me. If I have a single-row 18 key half, where each switch connects different GPIO pin to ground, is |
|
Toggle mode would not work with single switches. It is intended for 2, 3, or 4 way slider switches. kurtis originally developed it for the selector switch BT1/BT2/USB on the electronic materials office Altar-I, and I have not seen many other boards that use similar switches, so it's pretty niche. Those switches always have at least one GPIO shorted to GND which leads to very high battery draw even in idle. Toggle mode circumvents this, by disabling keyscan on a pin as soon as it is switched to ON, then reenabling it the moment another pin goes to ON, and disabling that pin. On single keyboard pushbuttons wired from GPIO to GND that issue does not exist, as they are only drawing power when actively pressed down by the user, and once disabled they would never be reenabled as the MCU can not know when it is depressed. |
An updated version of #1173. Currently being tested by @ebastler without any issues thus far.
Implements a
toggle-modeboolean to direct-wire kscans to disable pullup/pulldown resistors on active pins, removing the 244.4uA quiescent current that would otherwise exist without this feature.