Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behaviors): Adding require-prior-idle-ms for combos and hold-taps #1387

Merged
merged 8 commits into from
Oct 3, 2023

Commits on Sep 24, 2023

  1. refactor(behaviors): Giving global-quick-tap its own term

    Detaching the global-quick-tap functionality from the quick-tap term.
    This makes way for two improvements:
    
    1. This functionality can be added to combos under a unified name
       'global-quick-tap-ms'.
    
    2. This allows users to set a lower term for the 'global-quick-tap'
       (typically ~100ms), and a higher term for the regular
       quick-tap (typically ~200ms)
    
    This deprecates the global-quick-tap option, however if it is set, the
    quick-tap-ms value will be copied to global-quick-tap-ms.
    andrewjrae committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    c50ad40 View commit details
    Browse the repository at this point in the history
  2. feat(behaviors): Adding global-quick-tap-ms for combos

    This brings the 'global-quick-tap' functionality to combos by filtering
    out candidate combos that fell within their own quick tap term.
    
    I also replaced `return 0` with `return ZMK_EV_EVENT_BUBBLE` where appropriate.
    (I assume this was done in past as it is similar to errno returning, but
    being that this is to signify an event type I find this more clear)
    andrewjrae committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    8e69f8c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f2dc8ee View commit details
    Browse the repository at this point in the history
  4. refactor(docs): Applying suggestions for gqt from @caksoylar

    Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
    andrewjrae and caksoylar committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    c54acd4 View commit details
    Browse the repository at this point in the history
  5. refactor(behaviors): global-quick-tap -> require-prior-idle

    Renaming global-quick-tap-ms to require-prior-idle.
    andrewjrae committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    2a5f110 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f6aa320 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. refactor(docs): Apply suggestions from @caksoylar

    Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
    andrewjrae and caksoylar committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    b87d237 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Configuration menu
    Copy the full SHA
    48c9a8a View commit details
    Browse the repository at this point in the history