Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(board): add puchi_ble_v1 to boards #1445

Merged
merged 5 commits into from Sep 5, 2022

Conversation

BenRoe
Copy link
Contributor

@BenRoe BenRoe commented Aug 31, 2022

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

Hi,
my name is Ben from Keycapsss.com. The Puchi-BLE is a nrfMicro 1.3 fork.
I am in contact with @joric (creator of the nrfMicro). He is fine with the fork.
The board is tested and works.

I have encapsulate board (nrfmicro_13 -> puchi_ble_v1) for future changes.
I am not sure if all files have proper Copyright + License headers. If something is missing, let me know and i will change it.

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to check all the copyright and license headers on every file.

Thanks!

app/boards/arm/puchi_ble/puchi_ble_v1.yml Outdated Show resolved Hide resolved
app/boards/arm/puchi_ble/Kconfig Outdated Show resolved Hide resolved
app/boards/arm/puchi_ble/Kconfig Outdated Show resolved Hide resolved
app/boards/arm/puchi_ble/Kconfig.board Outdated Show resolved Hide resolved
app/boards/arm/puchi_ble/Kconfig.defconfig Outdated Show resolved Hide resolved
app/boards/arm/puchi_ble/Kconfig.defconfig Outdated Show resolved Hide resolved
@BenRoe
Copy link
Contributor Author

BenRoe commented Sep 5, 2022

@petejohanson all requested code changes should be fixed now.

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one outstanding question.

@petejohanson petejohanson merged commit 41bfc56 into zmkfirmware:main Sep 5, 2022
@BenRoe BenRoe deleted the puchi_ble branch September 6, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants