Bugfix: make tap dances work on a combo #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okke-formsma
changed the title
okke-formsma
force-pushed
the
test-combo-tap-dance
branch
from
8e795b4
to
4ff2449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tap-dances did not work because they intercepted the keypresses from combos before the combos could trigger.
By moving the tap-dance behavior lower in the CMakeList, their event handlers are triggered after combos, causing the right sequence of events so tap-dances can be triggered by a combo.
Test included in code. Tested on a board by cryptanon: