Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shields): Add splitkb.com Aurora Corne. #1520

Merged
merged 1 commit into from Nov 11, 2022
Merged

feat(shields): Add splitkb.com Aurora Corne. #1520

merged 1 commit into from Nov 11, 2022

Conversation

petejohanson
Copy link
Contributor

@petejohanson petejohanson commented Nov 4, 2022 •
edited

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@petejohanson petejohanson added enhancement New feature or request shields PRs and issues related to shields labels Nov 4, 2022
@petejohanson petejohanson self-assigned this Nov 4, 2022
@petejohanson petejohanson merged commit a904895 into zmkfirmware:main Nov 11, 2022
@manna-harbour manna-harbour mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicell Nicell Nicell approved these changes

Assignees

@petejohanson petejohanson

Labels
enhancement New feature or request shields PRs and issues related to shields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petejohanson @Nicell