fix(boards): Fix XIAO BLE voltage divider config. #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
added
bug
|
Tested, working. Battery percentage reflects my external measured voltage off the battery. |
* Use proper resistor value for the `output-ohms` property.
petejohanson
force-pushed
the
boards/xiao-ble-voltaged-divider-fix
branch
from
c416412
to
0b93f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output-ohmsproperty.Found this bug in my own testing, and the fix came from
sctanfon Discord. Reviewing the schematic confirms that's the proper fix.