Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boards): Polarity works CKP Series #1547

Merged
merged 8 commits into from Apr 25, 2023
Merged

Conversation

ReFil
Copy link
Contributor

@ReFil ReFil commented Nov 19, 2022

Adds support for the CKP family of boards in stock at many retailers
BT60V2 ANSI Hotswap, ISO Hotswap, ANSI Lowpro and soldered BT65 ANSI Hotswap, ISO Hotswap and soldered BT75 ANSI Hotswap and soldered

The BT65 and BT75 are stylised as btXX_v1 in order to maintain compatibility with customers existing zmk-config setups in the same way the BT60 V1 was handled when merged into main.

CKP boards have identical pinmapping between hotswap and soldered so there's only one set of defconfig, dts, keymap, yaml and yml files per size.

I've tested every keymap on every board where it makes sense, and the pinmapping commonality means flashing the wrong firmware isn't a serious screw up, and you can even get back into bootloader with a keypress most times, and the physical reset button will always work. I've also tried to standardise important control keys (BT_CLR, &bootloader etc etc) to the best of my ability.

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half (N/A)
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out (N/A)
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

Adds support for the CKP family of boards
BT60V2 ANSIHotswap, ISO Hotswap, ANSI Lowpro and soldered
BT65 ANSI Hotswap, ISO Hotswap and soldered
BT75 ANSI Hotswap and soldered

The BT65 and BT75 are stylised as btXX_v1 in order to maintain compatibility with customers existing zmk-config setups in the same way the BT60 V1 was handled when merged into main.

CKP boards have identical pinmapping between hotswap and soldered so there's only one set of defconfig, dts, keymap, yaml and yml files per size
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few items.

app/boards/arm/ckp/Kconfig.defconfig Outdated Show resolved Hide resolved
app/boards/arm/ckp/Kconfig.defconfig Outdated Show resolved Hide resolved
app/boards/arm/ckp/Kconfig Show resolved Hide resolved
app/boards/arm/ckp/bt60_v2_defconfig Outdated Show resolved Hide resolved
app/boards/arm/ckp/bt60_v2_defconfig Outdated Show resolved Hide resolved
app/boards/arm/ckp/bt65_v1_defconfig Outdated Show resolved Hide resolved
app/boards/arm/ckp/bt65_v1_defconfig Outdated Show resolved Hide resolved
app/boards/arm/ckp/bt75_v1_defconfig Outdated Show resolved Hide resolved
app/boards/arm/ckp/bt75_v1_defconfig Outdated Show resolved Hide resolved
@petejohanson
Copy link
Contributor

@ReFil Please rebase, we had some GHA bugs a while ago that have since been fixed.

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit db08e04 into zmkfirmware:main Apr 25, 2023
16 checks passed
@ReFil ReFil deleted the ckp branch March 6, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants