Added Waterfowl shield #1554
Added Waterfowl shield #1554
Conversation
This reverts commit 4dd30c8.
| config ZMK_KEYBOARD_NAME | ||
| default "Waterfowl" | ||
|
|
||
| config ZMK_SPLIT_BLE_ROLE_CENTRAL |
There was a problem hiding this comment.
| config ZMK_SPLIT_BLE_ROLE_CENTRAL | |
| config ZMK_SPLIT_ROLE_CENTRAL |
|
|
||
| config LVGL_VER_RES_MAX | ||
| default 64 | ||
|
|
There was a problem hiding this comment.
The two resolution Kconfigs are no longer necessary since da209c4
| RC(0,0) RC(0,1) RC(0,2) RC(0,3) RC(0,4) RC(0,5) RC(0,6) RC(0,7) RC(0,8) RC(0,9) | ||
| RC(1,0) RC(1,1) RC(1,2) RC(1,3) RC(1,4) RC(1,5) RC(1,6) RC(1,7) RC(1,8) RC(1,9) | ||
| RC(2,0) RC(2,1) RC(2,2) RC(2,3) RC(2,4) RC(2,5) RC(2,6) RC(2,7) RC(2,8) RC(2,9) | ||
| RC(3,0) RC(3,1) RC(3,2) RC(3,3) RC(3,4) RC(3,5) RC(3,6) RC(3,7) RC(3,8) RC(3,9) |
There was a problem hiding this comment.
There appears to be space/tab mixup on the above 9 lines, I'd stick to one or the other.
| &pro_micro_i2c { | ||
| status = "okay"; | ||
|
|
||
| ssd1306@3c { |
There was a problem hiding this comment.
You need to add a label to this node (oled: ssd1306@3c) then use it in the chosen node above like zephyr,display = &oled;, see example at https://github.com/zmkfirmware/zmk/blob/main/app/boards/shields/corne/corne.dtsi#L11
| &kp Q &kp W &kp E &kp R &kp T &kp Y &kp U &kp I &kp O &kp P | ||
| &mt LGUI A &mt LALT S &mt LCTRL D &mt LSHFT F &kp G &kp H &mt LSHFT J &mt LCTRL K &mt LALT L &mt LGUI SEMI | ||
| &kp Z &kp X &kp C &kp V &kp B &kp N &kp M &kp COMMA &kp DOT &kp FSLH | ||
| &kp N1 < 3 DEL < 1 SPACE &kp TAB &kp N2 &kp N3 &kp ESC &kp BSPC < 2 RET &kp N4 |
There was a problem hiding this comment.
Some tab/space mixup between left/right blocks in the layer definitions as well, it throws off the alignment when tabstop is set to 8 (Github default)
| * `-----' `--------------------' `--------------------' `-----' | ||
| */ | ||
| bindings = < | ||
| &kp PRCNT &kp LS(SQT) &kp LBKT &kp RBKT &kp NON_US_BSLH &kp RA(GRAVE) &kp LS(GRAVE) &kp CARET &trans &trans |
There was a problem hiding this comment.
The default keymap seems to be set for a UK layout and this is unusual compared to the other board/shields in the repo. I wanted to point it out but I don't really have an opinion one way or the other on whether this is wrong or not. It will not work as expected with US keyboard layouts.
OLED not yet tested
petejohanson
added
enhancement
Board/Shield Check-list
.zmk.ymlmetadata file added&pro_microused in favor of&pro_micro_d/aif applicable.conffile has optional extra features commented out