Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(boards): Add support for nRF5340 DK #1562

Merged
merged 2 commits into from Dec 8, 2022
Merged

feat(boards): Add support for nRF5340 DK #1562

merged 2 commits into from Dec 8, 2022

Conversation

joelspadin
Copy link
Collaborator

Added overlays to support building for the nRF5340 development kit.

Also added some documentation on how to build and flash ZMK for dual- chip Bluetooth configurations, with an example for the nRF5340.

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@joelspadin joelspadin added the board PRs and issues related to boards. label Dec 1, 2022
petejohanson
petejohanson reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on the overlay.

app/boards/nrf5340dk_nrf5340_cpuapp.overlay Outdated Show resolved Hide resolved
@joelspadin
feat(boards): Add support for nRF5340 DK
c0bd9b6 
Added overlays to support building for the nRF5340 development kit.

Also added some documentation on how to build and flash ZMK for dual-
chip Bluetooth configurations, with an example for the nRF5340.
caksoylar
caksoylar approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me w.r.t. docs, one point regarding pinning docs version.

docs/docs/development/build-flash.md Outdated Show resolved Hide resolved
@joelspadin @caksoylar
fix(docs): Pin Zephyr docs links to a version
4715973 
Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
petejohanson
petejohanson approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit 6ccb528 into zmkfirmware:main Dec 8, 2022
@joelspadin joelspadin deleted the nrf5340-support branch December 8, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petejohanson petejohanson petejohanson approved these changes

@caksoylar caksoylar caksoylar approved these changes

Assignees
No one assigned
Labels
board PRs and issues related to boards.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joelspadin @petejohanson @caksoylar