feat(display): Add config to show battery level in percentage #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works fine 👍🏻 |
|
It's good that while charging only the USB logo appears in the top left corner, so overlapping is not likely to occur in real world usage. |
petejohanson
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Kconfig
CONFIG_ZMK_WIDGET_BATTERY_STATUS_SHOW_PERCENTAGEfor battery status widget. When set, show battery level in percentage text instead of using battery icons.Unfortunately it looks to me there can be issues with widgets overlapping while charging with nice!view resolution and font sizes. This is an emulation, haven't tested on the actual shield yet:
