Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leeloo v2 and Leeloo-Micro v1 updates to support Zephyr 3.2 #1762

Merged
merged 20 commits into from Jul 17, 2023

Conversation

ClicketySplit
Copy link
Contributor

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out

@petejohanson
Copy link
Contributor

Can you please rebase to handle the conflicts?

@ClicketySplit
Copy link
Contributor Author

Hi @petejohanson!

Thank you very much; I was able to rebase, yet, I found out that I didn't have pre-commit installed. I was able to install and run; everything seems to be okay now.

:)

@ClicketySplit ClicketySplit changed the title Leeloo-Micro v1 updates to support Zephyr 3.2 Leeloo v2 and Leeloo-Micro v1 updates to support Zephyr 3.2 Apr 26, 2023
Copy link
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One main thought on first view. Then I wondered whether we could do revisions for this rather than two separate shields. I know we discovered it after the nice!nano v2 came out, and I don't recall if any other "revision" items have been committed yet, so I wanted to revisit that now. I'm not sure if board revisions also work with shields, but they can be read about here.

app/boards/shields/leeloo/Kconfig.shield Show resolved Hide resolved
@ClicketySplit ClicketySplit requested a review from Nicell June 4, 2023 05:33
@caksoylar caksoylar added the shields PRs and issues related to shields label Jun 10, 2023
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general, aside from the issues I noted.

Can you also update the year on copyright headers to 2023?

app/boards/shields/leeloo/leeloo.conf Outdated Show resolved Hide resolved
app/boards/shields/leeloo/README.md Outdated Show resolved Hide resolved
app/boards/shields/leeloo/README.md Show resolved Hide resolved
app/boards/shields/leeloo/leeloo_common.dtsi Outdated Show resolved Hide resolved
app/boards/shields/leeloo_micro/README.md Outdated Show resolved Hide resolved
app/boards/shields/leeloo_micro/leeloo_micro.dtsi Outdated Show resolved Hide resolved
app/boards/shields/leeloo_micro/leeloo_micro_common.dtsi Outdated Show resolved Hide resolved
@Nicell Nicell requested a review from petejohanson July 17, 2023 21:25
@petejohanson petejohanson merged commit aaf9958 into zmkfirmware:main Jul 17, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants