fix(bluetooth): Passkey pairing improvements. #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
added
enhancement
petejohanson
force-pushed
the
bluetooth/passkey-improvements
branch
from
68c366a
to
a517857
Compare
|
Looks good to me and working as expected so far, tested on Windows 11, Android, iOS and iPad OS. One thing that might be good to note (maybe as a sentence in the config table item?): Existing paired profiles require re-pairing after enabling this option. |
* Capture the last 6 entered digits, and then require pressing Enter/Return to submit the entered digits. This matches the messaging shown on hosts regarding how to complete pairing. * Fix the wording on the Kconfig menu item to accurately describe the feature.
petejohanson
force-pushed
the
bluetooth/passkey-improvements
branch
from
a517857
to
e9ebca5
Compare
Good call. Added a note in parentheses there. |
caksoylar
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enter/Return to submit the entered digits. This matches the
messaging shown on hosts regarding how to complete pairing.
the feature.
Tested on Linux w/ GNOME and on Android, both properly show the expected dialog upon pairing, and pairing only succeeds when a valid value is typed in on the keyboard, followed by pressing Enter/Return.