Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shields): Add splitkb.com Aurora Sofle #1864

Merged
merged 1 commit into from Jul 23, 2023
Merged

feat(shields): Add splitkb.com Aurora Sofle #1864

merged 1 commit into from Jul 23, 2023

Conversation

petejohanson
Copy link
Contributor

@petejohanson petejohanson commented Jul 11, 2023 •
edited

  • Add new shield for splitkb.com Aurora Sofle, supporting keys, encoder(s), displays, and RGB.

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@petejohanson petejohanson added enhancement New feature or request shields PRs and issues related to shields labels Jul 11, 2023
@petejohanson petejohanson self-assigned this Jul 11, 2023
@petejohanson
Copy link
Contributor Author

Just forced pushed some fixes for the matrix definition.

@petejohanson petejohanson marked this pull request as ready for review July 21, 2023 20:16
caksoylar
caksoylar reviewed Jul 21, 2023
View reviewed changes
app/boards/shields/splitkb_aurora_sofle/Kconfig.defconfig Outdated Show resolved Hide resolved
app/boards/shields/splitkb_aurora_sofle/splitkb_aurora_sofle.conf Show resolved Hide resolved
app/boards/shields/splitkb_aurora_sofle/boards/nice_nano.overlay Show resolved Hide resolved
app/boards/shields/splitkb_aurora_sofle/splitkb_aurora_sofle.dtsi Outdated
left_encoder: left_encoder {
compatible = "alps,ec11";
label = "L_ENCODER";
resolution = <4>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be updated with the new encoder config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, attempting to match the encoder's sold by splitkb: https://splitkb.com/collections/keyboard-parts/products/industrial-rotary-encoder

app/boards/shields/splitkb_aurora_sofle/splitkb_aurora_sofle.keymap Show resolved Hide resolved
app/boards/shields/splitkb_aurora_sofle/splitkb_aurora_sofle.keymap Outdated Show resolved Hide resolved
app/boards/shields/splitkb_aurora_sofle/splitkb_aurora_sofle.keymap Outdated Show resolved Hide resolved
app/boards/shields/splitkb_aurora_sofle/splitkb_aurora_sofle.keymap Outdated Show resolved Hide resolved
app/boards/shields/splitkb_aurora_sofle/splitkb_aurora_sofle.zmk.yml Show resolved Hide resolved
@petejohanson petejohanson force-pushed the shields/splitkb-aurora-sofle branch 2 times, most recently from 80e2068 to 744f634 Compare July 22, 2023 08:10
caksoylar
caksoylar approved these changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one indent issue with the new steps properties, and copyright years need updating. Otherwise looks good to me.

app/boards/shields/splitkb_aurora_sofle/splitkb_aurora_sofle.dtsi Outdated Show resolved Hide resolved
app/boards/shields/splitkb_aurora_sofle/splitkb_aurora_sofle.dtsi Outdated Show resolved Hide resolved
@petejohanson @caksoylar
feat(shields): Add splitkb.com Aurora Sofle
1569705 
* Add new shield for splitkb.com Aurora Sofle, supporting
  keys, encoder(s), displays, and RGB.

Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
@petejohanson petejohanson merged commit f743d57 into zmkfirmware:main Jul 23, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caksoylar caksoylar caksoylar approved these changes

Assignees

@petejohanson petejohanson

Labels
enhancement New feature or request shields PRs and issues related to shields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petejohanson @caksoylar