Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shields): Add splitkb.com Aurora Helix #1873

Merged
merged 1 commit into from Sep 4, 2023
Merged

feat(shields): Add splitkb.com Aurora Helix #1873

merged 1 commit into from Sep 4, 2023

Conversation

petejohanson
Copy link
Contributor

@petejohanson petejohanson commented Jul 17, 2023 •
edited

  • Add new shield for splitkb.com Aurora Helix, supporting keys, encoder(s), displays, and RGB.

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@petejohanson petejohanson added enhancement New feature or request shields PRs and issues related to shields labels Jul 17, 2023
@petejohanson petejohanson self-assigned this Jul 17, 2023
@harvey-splitkb
Copy link

Just tested it and works without any problems!

@petejohanson petejohanson marked this pull request as ready for review September 3, 2023 06:20
caksoylar
caksoylar approved these changes Sep 3, 2023
View reviewed changes
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are just a few nits I noted.

app/boards/shields/splitkb_aurora_helix/splitkb_aurora_helix.conf Outdated Show resolved Hide resolved
app/boards/shields/splitkb_aurora_helix/splitkb_aurora_helix.keymap Outdated Show resolved Hide resolved
app/boards/shields/splitkb_aurora_helix/splitkb_aurora_helix_left.overlay Outdated Show resolved Hide resolved
@petejohanson
feat(shields): Add splitkb.com Aurora Helix
46b2d97 
* Add new shield for splitkb.com Aurora Helix, supporting
  keys, encoder(s), displays, and RGB.
@petejohanson petejohanson merged commit 647945d into zmkfirmware:main Sep 4, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caksoylar caksoylar caksoylar approved these changes

Assignees

@petejohanson petejohanson

Labels
enhancement New feature or request shields PRs and issues related to shields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petejohanson @harvey-splitkb @caksoylar