fix(split): reserve peripheral slot before stopping scanning #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudongzheng
commented
Sep 2, 2023
app/src/split/bluetooth/central.c
Outdated
|
|
||
| // Reserve peripheral slot. Once the central has bonded to its peripherals, | ||
| // the peripheral MAC addresses will be validated internally and the slot | ||
| // reservation will fail if there is a mismatch. | ||
| int slot_idx = reserve_peripheral_slot(addr); | ||
| if (slot_idx < 0) { | ||
| LOG_ERR("Failed to reserve peripheral slot (err %d)", slot_idx); |
There was a problem hiding this comment.
In the context of central being in the vicinity of multiple ZMK peripherals, this is not really an error. I've changed it to LOG_INF("unable to reserve peripheral slot ..."). Let me know if you think LOG_ERR or LOG_WRN is more suitable.
xudongzheng
force-pushed
the
reserve-slot-pr
branch
from
4befa84
to
10e7390
Compare
In the event that the peripheral MAC address does not match, this allows scanning to continue.
xudongzheng
force-pushed
the
reserve-slot-pr
branch
from
10e7390
to
cc9cd8c
Compare
petejohanson
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that the peripheral MAC address does not match, this allows scanning to continue.