Refactor driver into proper Zephyr module, driver tweaks #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
added
core
petejohanson
force-pushed
the
core/module-intergration-clean-up
branch
2 times, most recently
from
7bbb6d5
to
3334e49
Compare
* Align our driver module layout to properly match Zephyr conventions, allowing proper CMake setup to amend the library for each type of driver.
petejohanson
force-pushed
the
core/module-intergration-clean-up
branch
from
7e3f98c
to
f02dd1b
Compare
* Avoid APPLICATION stage and use the proper earlier stage for kscan drivers.
petejohanson
force-pushed
the
core/module-intergration-clean-up
branch
from
f02dd1b
to
b63621a
Compare
* Promote previously local debounce code from kscan drivers to exposed module lib, for use with other drivers as needed. * Refactor existing kscan driver to new "public" API.
petejohanson
force-pushed
the
core/module-intergration-clean-up
branch
from
b63621a
to
6185741
Compare
joelspadin
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a core refactor to bring our driver structure in line with the current Zephyr conventions for out-of-tree (OOT) drivers.
zephyr_library_amend()to actually amend the existing library for each driver type, instead of creating a new separate library for each of our driver types, duplicating things.moduledirectory, notdrivers, so our structure matches that of Zephyr, needed so thatzephyr_library_amend()uses the correct library name.