Add Boardsource 3x4 shield #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innovaker
added
enhancement
petejohanson
requested changes
Oct 27, 2020
|
|
||
| num_layer { | ||
| bindings = < | ||
| &tog 1 &kp NUM_7 &kp NUM_8 &kp NUM_9 |
There was a problem hiding this comment.
You should be able to make this first binding just &trans to be transparent to flow to the layer below.
| num_layer { | ||
| bindings = < | ||
| &tog 1 &kp NUM_7 &kp NUM_8 &kp NUM_9 | ||
| &mo 2 &kp NUM_4 &kp NUM_5 &kp NUM_6 |
There was a problem hiding this comment.
Ditto, should be able to be:
Suggested change
| &mo 2 &kp NUM_4 &kp NUM_5 &kp NUM_6 | |
| &trans &kp NUM_4 &kp NUM_5 &kp NUM_6 |
|
|
||
| }; | ||
|
|
||
| bt_unpair_combo: bt_unpair_combo { |
There was a problem hiding this comment.
The unpair combo stuff has been replaced by the &bt behavior and the settings clear UF2 images when really needed, this should be removed.
MangoIV
pushed a commit
to MangoIV/zmk
that referenced
this pull request
Dec 18, 2020
Add Boardsource 3x4 shield
tyalie
pushed a commit
to tyalie/zmk
that referenced
this pull request
Nov 15, 2022
Add Boardsource 3x4 shield
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included keymap contains 4 layers - a nav laver, a num(pad) layer, a bluetooth layer, and an extended F-layer (F13-F23)
This shield has been tested with a nice!nano board. Thanks to the awesome documentation, this implementation was relatively painless!