Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boardsource 3x4 shield #296

Merged
merged 3 commits into from Oct 28, 2020
Merged

Conversation

neegool
Copy link
Contributor

@neegool neegool commented Oct 24, 2020

The included keymap contains 4 layers - a nav laver, a num(pad) layer, a bluetooth layer, and an extended F-layer (F13-F23)

This shield has been tested with a nice!nano board. Thanks to the awesome documentation, this implementation was relatively painless!

@innovaker innovaker added enhancement New feature or request shields PRs and issues related to shields labels Oct 25, 2020
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a whole, this looks great! Just a few minor comments.

Thanks.


num_layer {
bindings = <
&tog 1 &kp NUM_7 &kp NUM_8 &kp NUM_9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to make this first binding just &trans to be transparent to flow to the layer below.

num_layer {
bindings = <
&tog 1 &kp NUM_7 &kp NUM_8 &kp NUM_9
&mo 2 &kp NUM_4 &kp NUM_5 &kp NUM_6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, should be able to be:

Suggested change
&mo 2 &kp NUM_4 &kp NUM_5 &kp NUM_6
&trans &kp NUM_4 &kp NUM_5 &kp NUM_6


};

bt_unpair_combo: bt_unpair_combo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unpair combo stuff has been replaced by the &bt behavior and the settings clear UF2 images when really needed, this should be removed.

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@petejohanson petejohanson merged commit 73c83e8 into zmkfirmware:main Oct 28, 2020
1 check passed
MangoIV pushed a commit to MangoIV/zmk that referenced this pull request Dec 18, 2020
tyalie pushed a commit to tyalie/zmk that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants