Implement grave-escape #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okke-formsma
force-pushed
the
modmorph
branch
from
2f60b8a
to
8bc503e
Compare
|
@Nicell can you test this PR? |
|
@okke-formsma It works perfectly on my nice!60. Thanks so much for this! |
|
bump @okke-formsma any chance for a rebase / re-ask for @petejohanson review? i just spent some time with the mod-morph implementation and it works great i was able to create a flavor of grave escape that works better for my overall usage patterns than a vanilla grave escape implementation 👍 |
okke-formsma
force-pushed
the
modmorph
branch
from
c17d6bf
to
5b8f12a
Compare
|
I've rebased and it's ready to go. @petejohanson can you have a look? It's been tested by @mcrosson and @Nicell. |
okke-formsma
force-pushed
the
modmorph
branch
from
5b8f12a
to
3c223fa
Compare
petejohanson
requested changes
Jan 21, 2021
okke-formsma
force-pushed
the
modmorph
branch
from
3c223fa
to
8ba5fd7
Compare
okke-formsma
force-pushed
the
modmorph
branch
from
8ba5fd7
to
b872ca1
Compare
petejohanson
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #85
this implementation adds grave-escape, but is implemented in such a way that other "mod-morphs" can be created easily as discussed in the ticket.