Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp code quality checking by adding Ruff and mypy #13

Merged
merged 5 commits into from
Feb 25, 2023
Merged

Revamp code quality checking by adding Ruff and mypy #13

merged 5 commits into from
Feb 25, 2023

Conversation

zmoog
Copy link
Owner

@zmoog zmoog commented Feb 25, 2023 •
edited

Motivation

I want to revising the linters, static type checkers used in all my pet projects. Using axios to find the right mix of tools.

Change description

  • Drop flakes8 and add mypy for linting
  • Add mypy for static type checking
  • Set Python 3.8 as new minimum required version

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are appropriately filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • Docs are updated (at least the README.md, if needed).
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well-formatted.

@zmoog zmoog self-assigned this Feb 25, 2023
@zmoog zmoog added the enhancement New feature or request label Feb 25, 2023
@zmoog zmoog marked this pull request as ready for review February 25, 2023 08:09
@zmoog zmoog changed the title Add ruff and mypy Code checking: add ruff and mypy Feb 25, 2023
@zmoog zmoog changed the title Code checking: add ruff and mypy Revisit code checking by adding Ruff and mypy Feb 25, 2023
@zmoog zmoog force-pushed the zmoog/linting branch 5 times, most recently from 97ca1e8 to 6254548 Compare February 25, 2023 08:55
@zmoog zmoog changed the title Revisit code checking by adding Ruff and mypy Revamp code quality checking by adding Ruff and mypy Feb 25, 2023
@zmoog zmoog merged commit 0b25663 into main Feb 25, 2023
@zmoog zmoog deleted the zmoog/linting branch February 25, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmoog zmoog

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zmoog