refactor getMetricHistoryData endpoint (#20)

zmops · Feb 21, 2023 · a18aff8 · a18aff8
1 parent c314d09
commit a18aff8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/common/src/main/java/com/zmops/open/common/entity/dto/MetricsHistoryData.java b/common/src/main/java/com/zmops/open/common/entity/dto/MetricsHistoryData.java
@@ -24,7 +24,6 @@
 import lombok.NoArgsConstructor;
 
 import java.util.List;
-import java.util.Map;
 
 /**
  * 历史单指标数据
@@ -50,6 +49,7 @@ public class MetricsHistoryData {
     @Schema(title = "监控指标")
     private Field field;
 
-    @Schema(description = "监控指标历史值 instance<==>values")
-    private Map<String, List<Value>> values;
+    @Schema(description = "监控指标历史值")
+    private List<ValueRow> values;
+
 }
diff --git a/warehouse/src/main/java/com/zmops/open/warehouse/controller/MetricsDataController.java b/warehouse/src/main/java/com/zmops/open/warehouse/controller/MetricsDataController.java
@@ -38,6 +38,7 @@
 import org.springframework.web.bind.annotation.RequestParam;
 import org.springframework.web.bind.annotation.RestController;
 
+import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
 import java.util.stream.Collectors;
@@ -142,8 +143,15 @@ public ResponseEntity<Message<MetricsHistoryData>> getMetricHistoryData(
         } else {
             instanceValuesMap = historyDataStorage.getHistoryIntervalMetricData(monitorId, app, metrics, metric, instance, history);
         }
+        List<ValueRow> valueRows = new LinkedList<>();
+        if (instanceValuesMap != null) {
+            valueRows = instanceValuesMap.entrySet().stream().map(item -> ValueRow.builder()
+                    .instance(item.getKey())
+                    .values(item.getValue())
+                    .build()).collect(Collectors.toList());
+        }
         MetricsHistoryData historyData = MetricsHistoryData.builder()
-                .id(monitorId).metric(metrics).values(instanceValuesMap)
+                .id(monitorId).metric(metrics).values(valueRows)
                 .field(Field.builder().name(metric).type(CommonConstants.TYPE_NUMBER).build())
                 .build();
         return ResponseEntity.ok().body(new Message<>(historyData));