New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect sizes for plane and data slices for audio frames. #104

Open

tage64 wants to merge 1 commit into zmwangx:master from tage64:master

tage64 commented Jun 14, 2022

This pull request fixes two bugs:

The size of a plane created by frame::Audio::plane() for a packed audio frame with more than one channel was incorrectly set to the number of samples. It is now changed to be the number of samples times the number of channels.
The size of the slice created by frame::Audio::data(n) for n > 0 was incorrectly set to 0. It is now changed to be the same as for n=0.

Some explanations can be found at the doxygen documentation for AVFrame.
In particular:

◆ linesize

int AVFrame::linesize[AV_NUM_DATA_POINTERS]
...
For audio, only linesize[0] may be set. For planar audio, each channel plane must be the same size.

sagudev commented Aug 10, 2022

I just tested myself and can confirm that plane() is now working as intended.

nullsauce mentioned this pull request

Fix incorrect sizes for plane and data slices for audio frames. nullsauce/ffmpeg-rs#7

Merged


          Fix incorrect sizes for plane and data slices for audio frames.

447b047

tage64 force-pushed the master branch from af5166f to 447b047 Compare

October 14, 2022 17:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment