Implement support for non-exhaustive enums #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Polochon-street @zmwangx Excuse the ping, but I think this one of the simpler PRs that will help a lot of users living on the bleeding edge (mostly Arch users). I'd really appreciate some response so we can get this merged before the next release. |
|
Making a note that this would resolve #126 |
FreezyLemon
force-pushed
the
non-exhaustive-enum
branch
from
537ce6e
to
d6aa5a3
Compare
FreezyLemon
force-pushed
the
non-exhaustive-enum
branch
from
d6aa5a3
to
64a2134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires this
ffmpeg-sys-nextPR to be merged first.This PR adds the feature "non-exhaustive-enums" as requested in zmwangx/rust-ffmpeg-sys#46. This allows users to compile the ffmpeg-next crate(s) even when their locally installed FFmpeg dev files are newer than the target version.
Disabling the feature can be useful for library devs when updating ffmpeg-next to a newer version of FFmpeg. By disabling it, the compiler will error on enum matches that don't handle all enum values (making it harder to miss new enum values)
I think including this as a default feature is useful.