Add support for FFmpeg 7.0 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for taking care of this! As for #164, I've taken a look and made a comment, but it's not really my area of expertise, would you mind reviewing it too? I think the same comments apply to this one as zmwangx/rust-ffmpeg-sys#72 - let's wait til 7.0 landed somewhere to make sure the CI doesn't complain about anything :) |
|
Ok the CI is all green now :) |
|
Awesome! Thanks a lot for working on that 🙏 merging now |
|
aaand just published the crate. |
|
does the root readme need to be updated to mention 7.0 support? right now I see it only mentions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for FFmpeg 7.0. Depends on zmwangx/rust-ffmpeg-sys#72
Also, I wasn't able to find any easy way to install 7.0 in CI yet, so the CI is not updated
FFmpeg 7.0 removed a bunch of deprecated stuff, and the
ChannelLayoutis completely changed. I tried to implement new version in a least intrusive way.Also, since it's a major version bump, could you please try to review and merge #164 for 7.0? These features (especially new_with_codec) are very much needed (judging by the amount of opened PRs, and I need them myself too) and they are simple enough that merging them should be in scope even though this crate is in maintenance mode only
Thank you