Support for loading sounds from arbitrary directories on Android #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeduan
changed the title
|
Oops just noticed #15 |
|
@zmxv Could this be merged? |
|
@dvassilev in the meantime, you can use my fork by setting on your package.json the dependency like so: Hopefully this or the other PR will be merged soon! |
| @@ -86,7 +86,7 @@ public class MainActivity extends Activity implements DefaultHardwareBackBtnHand | |||
| } | |||
| ``` | |||
|
|
|||
| Save your sound clip files under the directory `android/app/src/main/res/raw`. | |||
| Save your sound clip files under the directory `android/app/src/main/res/raw` or any of the directories under Sound. | |||
There was a problem hiding this comment.
Save your sound clip files under the default directory android/app/src/main/res/raw, or any other directory in which case you need to pass the full path into the Sound constructor.
|
@zmxv Thanks for the feedback! Just made the changes you suggested |
|
Merged into master. Thank you for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds support for loading files on Android from arbitrary directories. This fixes #8 and fixes #5.
I tested loading a file from
RNFS.DocumentsDirectorywhich worked perfectly.Thanks!