Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for IRCv3.2 message tags #960

Closed
3ventic opened this issue May 5, 2015 · 9 comments
Closed

Add support for IRCv3.2 message tags #960

3ventic opened this issue May 5, 2015 · 9 comments

Comments

@3ventic
Copy link

3ventic commented May 5, 2015

The log module is not writing PRIVMSGs with IRCv3 tags into the log files. I'm not sure if it's specific tags causing the issue, all of the ones I'm trying to log have the same format and are from Twitch chat. Here's one such message captured with raw module:

[11:36:52] <*raw> IRC -> [@color=#FF0000;display-name=BrainsGames;emotes=;subscriber=0;turbo=0;user-type=;user_type= :brainsgames!brainsgames@brainsgames.tmi.twitch.tv PRIVMSG #alaskansavage :A S Hope all is well buddy!]

(More detailed here)

I've tried both ZNC 1.6.0 and 1.7.x-git-180-1cce7f6 with same results on Debian Jessie (8)
@DarthGandalf
Copy link
Member

Did you somehow force server to enable this capability? If not, why does server send tags at all?
ZNC doesn't yet support tags on IRC server connection.

@3ventic
Copy link
Author

3ventic commented May 6, 2015

Yes, by CAP REQ, because I need the information they contain.

@Mikaela
Copy link
Contributor

Mikaela commented May 6, 2015

You shouldn't cap req anything that your client & bouncer don't support so I would say that this is invalid unless you are requesting ZNC to start supporting tags.

@3ventic
Copy link
Author

3ventic commented May 6, 2015

It is more of a request to support tags. In my case, I'm running a script between ZNC and the server, so I simply started stripping the tags before they reach ZNC. I would still like tags available on my client while having ZNC log the chat, though.

I'd also like to point out that IRCv3 working group has ZNC 0.207 or later listed as a compliant client

@Mikaela
Copy link
Contributor

Mikaela commented May 6, 2015

I'd also like to point out that IRCv3 working group has ZNC 0.207 or later listed as a compliant client

That is a little inaccurate as the list is IRCv3**.1** compatible clients and when making the website they removed the mentioning of .1. Tags are in IRCv3.2 and I am not sure if any client understands them yet.

@DarthGandalf
Copy link
Member

In order to support some capability, cap req is not enough. One also needs to actually add support for it (the enabled tags, other protocol changes, etc)
For proper support of tags on server side some refactoring will be needed (e.g. #506)
IRCv3.1 is mostly supported, yes. 3.2 only partially

@DanielOaks DanielOaks mentioned this issue May 24, 2015
Closed
@Mikaela
Copy link
Contributor

Mikaela commented Jun 7, 2015

Could someone rename this issue to say "add support for server-tags" or something else that makes it clear what this is about?

@3ventic 3ventic changed the title PRIVMSGs with IRCv3 tags not logged Add support for IRCv3.2 message tags Jun 7, 2015
@3ventic
Copy link
Author

3ventic commented Jun 7, 2015

Sure. It only seemed to affect the logging module, but I don't know for certain.

@Mikaela Mikaela mentioned this issue Jun 24, 2015
Closed
BtbN added a commit to BtbN/znc that referenced this issue Jun 24, 2015
@BtbN
Add support for IRCv3.2 message tags
fafb769 
See http://ircv3.net/specs/core/message-tags-3.2.html

A Module still has to request a server CAP for tags to actualy get sent,
but now it doesn't have to parse them manualy anymore, and they don't
break stuff anymore if they appear unexpected(Module unloaded, stupid
server).

Closes znc#960
BtbN added a commit to BtbN/znc that referenced this issue Jun 25, 2015
@BtbN
Add support for IRCv3.2 message tags
e1d7ec8 
See http://ircv3.net/specs/core/message-tags-3.2.html

A Module still has to request a server CAP for tags to actualy get sent,
but now it doesn't have to parse them manualy anymore, and they don't
break stuff anymore if they appear unexpected(Module unloaded, stupid
server).

Closes znc#960
BtbN added a commit to BtbN/znc that referenced this issue Jun 25, 2015
@BtbN
Add support for IRCv3.2 message tags
058dd2c 
See http://ircv3.net/specs/core/message-tags-3.2.html

A Module still has to request a server CAP for tags to actualy get sent,
but now it doesn't have to parse them manualy anymore, and they don't
break stuff anymore if they appear unexpected(Module unloaded, stupid
server).

Closes znc#960
BtbN added a commit to BtbN/znc that referenced this issue Jun 25, 2015
@BtbN
Add support for IRCv3.2 message tags
c58ad77 
See http://ircv3.net/specs/core/message-tags-3.2.html

A Module still has to request a server CAP for tags to actualy get sent,
but now it doesn't have to parse them manualy anymore, and they don't
break stuff anymore if they appear unexpected(Module unloaded, stupid
server).

Closes znc#960
BtbN added a commit to BtbN/znc that referenced this issue Jun 25, 2015
@BtbN
Add support for IRCv3.2 message tags
8793bff 
See http://ircv3.net/specs/core/message-tags-3.2.html

A Module still has to request a server CAP for tags to actualy get sent,
but now it doesn't have to parse them manualy anymore, and they don't
break stuff anymore if they appear unexpected(Module unloaded, stupid
server).

Closes znc#960
BtbN added a commit to BtbN/znc that referenced this issue Jun 25, 2015
@BtbN
Add support for IRCv3.2 message tags
96080fe 
See http://ircv3.net/specs/core/message-tags-3.2.html

A Module still has to request a server CAP for tags to actualy get sent,
but now it doesn't have to parse them manualy anymore, and they don't
break stuff anymore if they appear unexpected(Module unloaded, stupid
server).

Closes znc#960
BtbN added a commit to BtbN/znc that referenced this issue Jun 25, 2015
@BtbN
Add support for IRCv3.2 message tags
897f996 
See http://ircv3.net/specs/core/message-tags-3.2.html

A Module still has to request a server CAP for tags to actualy get sent,
but now it doesn't have to parse them manualy anymore, and they don't
break stuff anymore if they appear unexpected(Module unloaded, stupid
server).

Closes znc#960
BtbN added a commit to BtbN/znc that referenced this issue Jun 26, 2015
@BtbN
Add support for IRCv3.2 message tags
d76e5e3 
See http://ircv3.net/specs/core/message-tags-3.2.html

A Module still has to request a server CAP for tags to actualy get sent,
but now it doesn't have to parse them manualy anymore, and they don't
break stuff anymore if they appear unexpected(Module unloaded, stupid
server).

Closes znc#960
BtbN added a commit to BtbN/znc that referenced this issue Jun 26, 2015
@BtbN
Add support for IRCv3.2 message tags
e8b4604 
See http://ircv3.net/specs/core/message-tags-3.2.html

A Module still has to request a server CAP for tags to actualy get sent,
but now it doesn't have to parse them manualy anymore, and they don't
break stuff anymore if they appear unexpected(Module unloaded, stupid
server).

Closes znc#960
BtbN added a commit to BtbN/znc that referenced this issue Jun 26, 2015
@BtbN
Add support for IRCv3.2 message tags
3f66a1c 
See http://ircv3.net/specs/core/message-tags-3.2.html

A Module still has to request a server CAP for tags to actualy get sent,
but now it doesn't have to parse them manualy anymore, and they don't
break stuff anymore if they appear unexpected(Module unloaded, stupid
server).

Closes znc#960
@jpnurmi
Copy link
Member

jpnurmi commented Aug 17, 2015

Solved by #1000. See CMessage::GetTags()

@jpnurmi jpnurmi closed this as completed Aug 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jpnurmi @DarthGandalf @Mikaela @3ventic