Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor duplicate code in crypt module. #1386

Merged
merged 1 commit into from
Mar 16, 2017

Conversation

Cizzle
Copy link
Contributor

@Cizzle Cizzle commented Mar 16, 2017

Moves code from OnUserMsg, OnUserNotice and OnUserAction to one function.

@codecov
Copy link

codecov bot commented Mar 16, 2017

Codecov Report

Merging #1386 into master will increase coverage by 0.09%.
The diff coverage is 53.57%.

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
+ Coverage    40.5%   40.59%   +0.09%     
==========================================
  Files         109      109              
  Lines       21313    21274      -39     
==========================================
+ Hits         8633     8637       +4     
+ Misses      12680    12637      -43
Impacted Files Coverage Δ
modules/crypt.cpp 56.58% <53.57%> (+8.1%)
src/FileUtils.cpp 49.85% <0%> (+0.57%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab34760...5ac9924. Read the comment docs.

@DarthGandalf
Copy link
Member

Thanks.
This is not what I meant - with CMessage API you wouldn't need so many parameters to FilterOutgoing function, but it's still much better than the duplicated code before.

@DarthGandalf DarthGandalf merged commit 29d4f20 into znc:master Mar 16, 2017
@Cizzle Cizzle deleted the feat_crypt_refactor branch March 17, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants