Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker support #8

Open
niekcandaele opened this issue Sep 22, 2020 · 2 comments · May be fixed by #9 or #47
Open

Docker support #8

niekcandaele opened this issue Sep 22, 2020 · 2 comments · May be fixed by #9 or #47

Comments

@niekcandaele
Copy link

Hey, thanks for picking up this repo! haste-server is really cool and I'm glad it's being revitalized.

I was wondering how you felt about adding Docker support? I have a semi-decent image locally and there's a couple of PRs for it in the old repo. I could try and clean it up and make a PR
@zneix
Copy link
Owner

zneix commented Sep 22, 2020 •
edited

Hello Niek, I'm also glad people appreciate what I am doing!

When I was browsing issues on upstream repo, I saw numerous Docker-related ones. I would gladly add Docker support and even wanted to, however while I have no experience with docker at all, there were other things that needed more work that I prioritized more.

If you have such knowledge about docker and you want to contribute, I will be more than happy to merge a PR with some good code! Just remember to follow rules in .eslintrc.json.
Also, since my fork got some attention around it (which is btw crazy and I never expected it to happen ;p), I will try to add some general contribution guidelines and workflows to make it more comfortable for you and other contributors to follow my specific style.

Thanks in advance!

@niekcandaele niekcandaele linked a pull request Sep 22, 2020 that will close this issue
Open
zneix added a commit that referenced this issue Sep 30, 2020
@zneix
Added all dependencies to package.json
376335a 
It seems to be a better practice to keep all dependencies documented in repo and package-lock, so there will be no issues with installing them manually. Even though there are more deps that self-hosters might not use, it makes it easier to change configuration and manage some things like docker images (see #8).
@zneix zneix mentioned this issue Sep 30, 2020
Merged
zneix added a commit that referenced this issue Sep 30, 2020
@zneix
Added all dependencies to package.json (#11)
8ad9278 
It seems to be a better practice to keep all dependencies documented in repo and package-lock, so there will be no issues with installing them manually. Even though there are more deps that self-hosters might not use, it makes it easier to change configuration and manage some things like docker images (see #8).
@eightysixed
Copy link

What about those of us running unRAID? Would you ever consider merging this into Community Apps for a simple docker container install?

SunRed pushed a commit to SunRed/haste-server that referenced this issue Feb 12, 2021
@zneix @SunRed
Added all dependencies to package.json (zneix#11)
114859a 
It seems to be a better practice to keep all dependencies documented in repo and package-lock, so there will be no issues with installing them manually. Even though there are more deps that self-hosters might not use, it makes it easier to change configuration and manage some things like docker images (see zneix#8).
@SunRed SunRed linked a pull request Feb 12, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@eightysixed @niekcandaele @zneix