Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netcdf format #62

Merged
merged 17 commits into from
Jun 17, 2019
Merged

Netcdf format #62

merged 17 commits into from
Jun 17, 2019

Conversation

znicholls
Copy link
Owner

@znicholls znicholls commented Jun 15, 2019

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added
  • Moved outstanding issues from Netcdf format #60 into OpenSCM

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

Closes #60

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #62 into master will decrease coverage by 0.18%.
The diff coverage is 95.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   97.64%   97.46%   -0.19%     
==========================================
  Files           8       10       +2     
  Lines         851      906      +55     
  Branches      113      129      +16     
==========================================
+ Hits          831      883      +52     
- Misses         14       16       +2     
- Partials        6        7       +1
Impacted Files Coverage Δ
src/netcdf_scm/iris_cube_wrappers.py 99.79% <100%> (ø) ⬆️
src/netcdf_scm/definitions.py 100% <100%> (ø)
src/netcdf_scm/cli.py 95.95% <100%> (+0.17%) ⬆️
src/netcdf_scm/io.py 90.9% <90.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a0cff...6c48d8b. Read the comment docs.

@znicholls znicholls marked this pull request as ready for review June 17, 2019 02:21
@znicholls znicholls merged commit 2fe0378 into master Jun 17, 2019
@znicholls znicholls mentioned this pull request Jun 17, 2019
Closed
33 tasks
@znicholls znicholls deleted the netcdf-format branch June 17, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netcdf format
1 participant