Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hfds reading #78

Closed
wants to merge 32 commits into from
Closed

hfds reading #78

wants to merge 32 commits into from

Conversation

znicholls
Copy link
Owner

@znicholls znicholls commented Aug 12, 2019 •
edited

Pull request

Please confirm that this pull request has done the following:

  • Implement is_land_data which can be used to dynamically adjust masks (check whether it should follow same logic as ocean i.e. assume the whole thing is land if the realm is land rather than using sftlf to do the split)
  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

@znicholls
Add ocean test files
944318a
@znicholls
Move to git lfs
322f856
@znicholls
Move to git lfs
ac8ef8f
@znicholls
Add test of reading hfds data
506c818
@znicholls
Add better ocean data for testing
2842aa5
@znicholls
Work out the tests I need to write
ad7a305
@znicholls
Remove areacello file for regridded test ocean data
a3db7d4
@znicholls
Add failing test for no land mask with ocean data
7701371
@znicholls
Add is_ocean_data property to cubes
cdb4fc4
@znicholls
Add ocean data notebook and fix handling of masking for ocean data
008afb1
@znicholls
Pass regridded hfds handling test
b42d69a
@znicholls
Calculate with non-native grids and areacello, hugely different answe…
7eed1a5 
…r though...
@znicholls
Setup for rest of ocean data handling
a921c33
@znicholls
Keep working through tests
b651aa4
@znicholls
Ready to clean up before thetao attempts
2cff2ae
@znicholls
Pass most tests
675810b
@znicholls
Add failing test of thetao handling
db56823
@znicholls
Add scratch implementation of depth info handling
1b58011
@znicholls
Add failing test of loading metadata automatically
c6a6c37
@znicholls
Setup to return to depth stuff later
5fc0031
@znicholls
Tidy up a bit
e96320d
@znicholls
Redo area mask logic
442219e
@znicholls
Pass all tests
f2a5c7a
@znicholls znicholls changed the title Hfds reading hfds reading Aug 12, 2019
@znicholls znicholls marked this pull request as ready for review August 12, 2019 10:57
@znicholls
Copy link
Owner Author

Closed in favour of #84

@znicholls znicholls closed this Aug 19, 2019
@znicholls znicholls deleted the hfds-reading branch August 28, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@znicholls