Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null safety migration #15

Closed
znjameswu opened this issue Nov 20, 2020 · 6 comments
Closed

Null safety migration #15

znjameswu opened this issue Nov 20, 2020 · 6 comments

Comments

@znjameswu
Copy link
Owner

The manual nnbd migration turns out to be easier than I had thought. Currently all tests are passing on the nnbd branch.

The prerelease version will be published once the following dependencies have migrated:

  • provider
  • flutter_svg
  • tuple (currently replaced with an internal implementation)
@creativecreatorormaybenot
Copy link
Contributor

You should probably redo some parts of the migration once upstream has migrated. Otherwise, you will lose the nullability information and just assume that everything from upstream that was not yet migrated is nullable.

I can also do that migration if you are interested :)

@znjameswu
Copy link
Owner Author

You should probably redo some parts of the migration once upstream has migrated. Otherwise, you will lose the nullability information and just assume that everything from upstream that was not yet migrated is nullable.

I can also do that migration if you are interested :)

Yes, that's the reason I've not yet merged it into the master. You can work on the nnbd branch.

@creativecreatorormaybenot
Copy link
Contributor

@znjameswu Sounds good - let's hope I will remember to do it once the packages have been migrated 😄

@znjameswu
Copy link
Owner Author

@creativecreatorormaybenot provider was updated yesterday so I've tried to update dependencies and they just seem to work. You can check them on the nnbd branch.

@creativecreatorormaybenot
Copy link
Contributor

@znjameswu Yep, nice! Looking good; great that all dependencies have the NNBD version now 😋

I think provider has had the null safety version for about a week now, but I completely forgot about this issue 🙈

Does that mean that you are done with the migration already? Or should I take a look into migrating it?
Would probably migrate from the master version - but no need to bother with it when you say that it is already done.

@znjameswu
Copy link
Owner Author

@creativecreatorormaybenot Yes I think I'm done with migrating and shall merge nnbd branch into master.

creativecreatorormaybenot added a commit to simpleclub-extended/flutter_math that referenced this issue Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants