Trap exceptions during generation #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asedOnR and HttpRequestPattern.negativeBasedOn
Renamed newBasedOnR and negativeBasedOnR, removing the R and eliminating the older newBasedOn and negativeBasedOn, which had been made into wrappers of their R methods in this branch.
Deleted all Feature.executeTest methods except 1, and cleaned it up
…ns but as test results
This reverts commit 2ebcc83.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Trap exceptions and return them as return values, rather than letting them bubble up naturally.
Why:
Sequences generate values just-in-time, so in some cases the usual exception handlers will not get a chance to fire and add metadata. It also becomes harder to reason about exceptions.
How:
HttpRequestPattern.newBasedOnreturnsSequence<ReturnValue<HttpRequestPattern>>, and this signature bubbles up. WithinHttpRequestPattern.newBasedOn:ReturnValueobjectsHttpRequestPatternrealisation time (flatMaps) are trapped (did this by implementing my ownflatMap) and returned as aReturnValueobject.We still validate the rows before running tests, in an attempt to catch errors early before running contract tests.
Checklist: