Android supports custom channel id

[summer88123]

No description provided.

[kneza23]

@zo0r this is really useful. Why not merge as this should be standard practice in new android apps.

As i see this is hardcoded. It probably should be exported as part of the config object when calling local notification.

private static final String NOTIFICATION_CHANNEL_ID = "rn-push-notification-channel-id";

[jbreuer95]

+1

[artmerlop]

+1

[dehypnosis]

+1, what disturbs this PR being merged?

[erhanbicer]

why isn't it merged?

[Dallas62]

Channel ID is generated based on configuration of the notification, does this PR fully address the problem or is just a workaround to get you own channel id ?

[rocboronat]

Please merge it. The code looks great and it also includes the introduction in the readme 😢

[rocboronat]

@summer88123 may you update the PR in order to avoid conflicts with master?

[Dallas62]

This change doesn't solve the issue of channel_id, it's just allow you to get a "custom" channel_id.
First of all, this change is focus on local notification only, so Remote notification still have the issue.
Then, if you change settings like sound, vibration or importance. The channel will ignore these changes.
If you want delete the channel, this will not be possible.

I know the current Library doesn't provide a good channel management, but I'm sure this change will not solve the issue of channel management and lead more issues on Github due to all cases listed.

[rocboronat]

Hey @Dallas62! Happy to see activity on this PR! 😄

What you say is correct, but it's something related to the Android framework, not this library.

If we apply this PR and the developer creates the notification channels on the Android side, that's it. We'll have all the power the Android notification channels give. In case the notification doesn't exist, it will crash, but it's a problem of the developer that hasn't created the notification channels properly.

What you said with it just allow you to get a "custom" channel_id. is the big change I need. Nothing else. It will let the user disable a kind of notification without disabling the other ones, and that has great value for both the user and the company behind the app.

[rocboronat]

Here's a screenshot of what this PR will let us do:

[Dallas62]

I will take a look into it,
But the PR is not compatible with recent changes,
I will push changes on dev ASAP

[rocboronat]

Thank you so much for your support @Dallas62 👌

[Dallas62]

#1232