Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove fishy reference from android project files #1226

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

tuncaulubilge
Copy link
Contributor

Addresses issue: #1169

Somehow a reference to a january.ai project found its way into the project, breaking android studio builds. This PR removes it.

@DaveTheFrontEndDev
Copy link

Please merge. I don't want to add a patch for this in my pipeline for this :/

@tuncaulubilge
Copy link
Contributor Author

@MrVann patch package is quite handy for situations like these https://www.npmjs.com/package/patch-package , until someone decides to review and merge this one...

@petekp
Copy link

petekp commented Jan 23, 2020

@zo0r Possible to merge this? It's still breaking Android builds.

@alexyangjie
Copy link

Please merge this. This error is breaking the Android studio.

@landorid
Copy link

This is still an issue in version 3.1.9

@iamrenejr
Copy link

Please merge. I cannot build on android studio due to this.

@phyzical
Copy link

phyzical commented Mar 5, 2020

Can confirm pr removes issue

@sharma0611
Copy link

Also +1, this PR fixes the issue.

@Dallas62 Dallas62 merged commit 49b5f22 into zo0r:master Apr 9, 2020
@twelve17
Copy link

Thank you @Dallas62 , may the schwartz be with you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet