Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fire date in notification response #1345

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

narender2031
Copy link
Contributor

No description provided.

@Dallas62
Copy link
Collaborator

Dallas62 commented Apr 9, 2020

Hi @narender2031,
Is it the same behaviour on Android ?
Thanks!

@narender2031
Copy link
Contributor Author

No in android they return the fire date. But in IOS no fire date returned. Also For this, you need to make changes in react-native-community/push-notification-ios check my PR for this
react-native-push-notification/ios#89

@Dallas62
Copy link
Collaborator

Dallas62 commented Apr 9, 2020

If I understand, this improvement make sense if they merge this PR:
react-native-push-notification/ios#89
You can ping me as soon as they merge your change, I will check this PR after.
Thanks!

@Dallas62 Dallas62 self-assigned this Apr 10, 2020
@narender2031
Copy link
Contributor Author

sure I will update you.

@Dallas62
Copy link
Collaborator

Hi @narender2031
The PR 89 is now merged, once it’s released, I will test it

@narender2031
Copy link
Contributor Author

@Dallas62 Thanks. Please update me if you have any issues.

@Dallas62
Copy link
Collaborator

Since this change doesn't break the library, I will merge this on dev branch and release it in the next release.
You will have to wait for the next release of this library and the iOS one.

@Dallas62 Dallas62 changed the base branch from master to dev May 27, 2020 16:51
@Dallas62 Dallas62 merged commit 725e5fe into zo0r:dev May 27, 2020
@narender2031
Copy link
Contributor Author

Thanks @Dallas62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants