Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing step for android manual installation #1363

Merged
merged 2 commits into from
Apr 12, 2020
Merged

Conversation

paddy57
Copy link
Contributor

@paddy57 paddy57 commented Apr 12, 2020

No description provided.

@Dallas62
Copy link
Collaborator

Hi @paddy57
Thanks for this PR
Are you sure this step is mandatory ?
As far as I know, the autolink should work on Android
Regards

@paddy57
Copy link
Contributor Author

paddy57 commented Apr 12, 2020

Hello, @Dallas62 I tried manual Android manual Installation, and after building an android project I got an error saying ReactNativePushNotificationPackag does not exist. And in order to solve, I had to add react-native-push-notification dependency in android build Gradle. So I think it's needed as auto-link does not work for me.

@Dallas62 Dallas62 merged commit 3508121 into zo0r:master Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants