Full Support BigPicture(BannerMode) and Fixed issue of largeIcon using url [Android] #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import Big Image Url and largeIconUrl feature for LocalNotification in android
admin2684
changed the title
|
I'm really waiting for this one. Hope it will be merged. |
Dallas62
reviewed
May 27, 2020
Comment on lines
+840
to
+842
| channel.setDescription(this.config.getChannelDescription()); | ||
| channel.enableLights(true); | ||
| channel.enableVibration(true); |
There was a problem hiding this comment.
This code is duplicate with L829-831.
| @@ -410,6 +449,7 @@ public void sendToNotificationCentre(Bundle bundle) { | |||
| notification.setVibrate(vibratePattern); | |||
| } | |||
|
|
|||
| soundUri = RingtoneManager.getDefaultUri(RingtoneManager.TYPE_NOTIFICATION); | |||
There was a problem hiding this comment.
This line introduce a regression by forcing sounds.
Comment on lines
+170
to
+171
| Log.d(TAG, "sendNotificationWithImage: bitmao log: " + image); | ||
| Log.d(TAG, "sendNotificationWithImage: bitmao log: " + largeIconImage); |
There was a problem hiding this comment.
A LOG_TAG constant already exist.
| @@ -57,6 +70,8 @@ | |||
| private static final long ONE_HOUR = 60 * ONE_MINUTE; | |||
| private static final long ONE_DAY = 24 * ONE_HOUR; | |||
|
|
|||
| private String TAG = "RNPushNotificationHelper"; | |||
There was a problem hiding this comment.
A LOG_TAG constant already exist.
| @@ -145,12 +160,15 @@ public void sendNotificationScheduledCore(Bundle bundle) { | |||
| } else { | |||
| getAlarmManager().setExact(AlarmManager.RTC_WAKEUP, fireDate, pendingIntent); | |||
| } | |||
| getAlarmManager().setExact(AlarmManager.RTC_WAKEUP, fireDate, pendingIntent); | |||
There was a problem hiding this comment.
This code is duplicate, result is:
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
if(allowWhileIdle && Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
getAlarmManager().setExactAndAllowWhileIdle(AlarmManager.RTC_WAKEUP, fireDate, pendingIntent);
} else {
getAlarmManager().setExact(AlarmManager.RTC_WAKEUP, fireDate, pendingIntent);
}
getAlarmManager().setExact(AlarmManager.RTC_WAKEUP, fireDate, pendingIntent);
} else {
getAlarmManager().set(AlarmManager.RTC_WAKEUP, fireDate, pendingIntent);
}
Comment on lines
+354
to
+358
| } else { | ||
| if (largeIconResId != 0 && (largeIcon != null || Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP)) { | ||
| notification.setLargeIcon(largeIconBitmap); | ||
| } | ||
| } |
There was a problem hiding this comment.
This code is also duplicate with L340-342
|
Thanks for your contribution, this helped to implement a solution to this. You can test the version on |
Dallas62
added a commit
that referenced
this pull request
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now this library (react-native-push-notification) can support these features:
Note: These changes has not effect on other features (Without remove other features)
Thanks to @tidianeb5
@Dallas62 Please merge this pull request