implement 'bigLargeIcon' for Android notifications #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dallas62
reviewed
Nov 3, 2020
| @@ -313,6 +313,8 @@ PushNotification.localNotification({ | |||
| bigText: "My big text that will be shown when notification is expanded", // (optional) default: "message" prop | |||
| subText: "This is a subText", // (optional) default: none | |||
| bigPictureUrl: "https://www.example.tld/picture.jpg", // (optional) default: undefined | |||
| bigLargeIcon: "ic_launcher", // (optional) default: undefined | |||
There was a problem hiding this comment.
I don't see how this parameter is used...
Can you check it ?
There was a problem hiding this comment.
Sorry, you're perfectly right, good catch!
I had only tested with url. Fixed it with another commit.
|
Thanks for this PR ! |
elburu
pushed a commit
to elburu/react-native-push-notification
that referenced
this pull request
Mar 12, 2023
* implement 'bigLargeIcon' for Android notifications * fix (non-url) bigLargeIcon Co-authored-by: hubsif <hubsif@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for BigLargeIcon, which is the large icon shown on the upper right when a picture or media notification is expanded (see here for a splendid explanation).
Currently, when you add a picture to a notification and use largeIcon for preview, when you expand the notification you will see both, the picture and it's same, just smaller preview on the upper right.
I think this doesn't look too nice and it's better to have the largeIcon disappear or set to something else (e.g. the app icon) in expanded view, which this change enables the users to.
That's also the reason why in the code I don't check for the bigLargeIcon to be present but always set it, which leads to the default behaviour that the largeIcon disappears when expanded.