Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create channel without sound #1779

Closed
wants to merge 1 commit into from
Closed

Create channel without sound #1779

wants to merge 1 commit into from

Conversation

alexhtcg
Copy link

Create channel without sound changes on RNPushNotificationHelper

Create channel without sound changes on RNPushNotificationHelper
@Dallas62
Copy link
Collaborator

Hi,

I think you can simply use an empty string for that, or lower the importance.
Regards.

@alexhtcg
Copy link
Author

Hi,

I think you can simply use an empty string for that, or lower the importance.
Regards.

Error on this line. I have tried with empty string.

soundName = soundName.substring(0, soundName.lastIndexOf('.'));

@Dallas62
Copy link
Collaborator

I will look into it, but not in that way.
Coming back to you ASAP.

@Dallas62 Dallas62 self-assigned this Dec 17, 2020
@alexhtcg
Copy link
Author

I will look into it, but not in that way.
Coming back to you ASAP.

Thanks

@Dallas62
Copy link
Collaborator

Dallas62 commented Dec 18, 2020

I didn't see it yesterday, but I was sure it was already implemented: #1736
It's not release yet, but soon.

@Dallas62 Dallas62 closed this Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants