Support using drawable as Android small icon #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May be we should update readme about local notifications for better understanding how should users setup this library on android
Update README.md
Dallas62
reviewed
Dec 23, 2020
There was a problem hiding this comment.
Hi @hojason117
Thanks for this PR, there is only one change missing to be merged 😉
| @@ -341,9 +344,9 @@ public void sendToNotificationCentreWithPicture(Bundle bundle, Bitmap largeIconB | |||
| String largeIcon = bundle.getString("largeIcon"); | |||
|
|
|||
| if (largeIcon != null && !largeIcon.isEmpty()) { | |||
| largeIconResId = res.getIdentifier(largeIcon, "mipmap", packageName); | |||
| largeIconResId = res.getIdentifier(largeIcon, "mipmap", packageName); | |||
There was a problem hiding this comment.
This should also include the same kind of condition, like it was made with smallIcon to get drawable.
There was a problem hiding this comment.
Same condition for large icon added 👍
Dallas62
approved these changes
Dec 23, 2020
|
Thanks for this PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using drawable resource as Android local notification small icon.
Default using drawable since Image Asset Studio puts notification icons in there.
fixes #1594