Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android missing channelId warning should now show #1995

Merged
merged 1 commit into from May 12, 2021

Conversation

gioragutt
Copy link
Contributor

Small one, would have been caught by TypeScript easily πŸ€·πŸ»β€β™‚οΈ

Small one, would have been caught by TypeScript easily πŸ€·πŸ»β€β™‚οΈ
@Dallas62 Dallas62 merged commit 7315f43 into zo0r:master May 12, 2021
@Dallas62
Copy link
Collaborator

Thanks !

@Dallas62
Copy link
Collaborator

Will release it ASAP

@wadhia-yash
Copy link

Hi @darryl-tan this warning is usually given in android as referring to create a channel for triggering the notification. As of Android O, creating a Notification instance requires a channel ID. This is to ensure that our notification belongs to a channel that can be managed by the user from their device settings. And as of solution for your problem is this:

const showNotification = (title, message, channelId, channelName) => {
  PushNotification.createChannel({
            channelId,
            channelName,
        });

  PushNotification.localNotification({
          channelId,
          title:title,
          message:message,
        });
}

@gioragutt gioragutt deleted the patch-1 branch June 6, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants