Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS repeated notification timing #2150

Merged
merged 1 commit into from Oct 1, 2021
Merged

Fix iOS repeated notification timing #2150

merged 1 commit into from Oct 1, 2021

Conversation

mmmoussa
Copy link
Contributor

For repetition over larger time intervals, the smaller time intervals within repeatsComponent need to be set to true in order to ensure the notification is delivered at the correct time. Without this fix, iOS scheduled repeating notifications are not sent correctly and do not match the Android behaviour.

I have tested this PR on my own app in prod and it fixes the issue correctly.

#2147 may be related.

For higher time intervals, the lower time intervals within `repeatsComponent` need to be set to `true` in order to ensure the notification is delivered at the correct time.
@MCElmo
Copy link

MCElmo commented Sep 24, 2021

+1 This fixed the issue for me

Copy link

@mohsenV1980 mohsenV1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. The repeatType will not work correctly without this fix

@Dallas62 Dallas62 changed the base branch from master to dev October 1, 2021 13:57
@Dallas62 Dallas62 merged commit cce3e49 into zo0r:dev Oct 1, 2021
@mmmoussa mmmoussa deleted the patch-1 branch October 1, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants