[Android] Remove default alert for silent push notifications #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superandrew213
commented
Apr 10, 2018
| @@ -29,7 +29,7 @@ public void onMessageReceived(String from, final Bundle bundle) { | |||
| JSONObject data = getPushData(bundle.getString("data")); | |||
| if (data != null) { | |||
| if (!bundle.containsKey("message")) { | |||
| bundle.putString("message", data.optString("alert", "Notification received")); | |||
| bundle.putString("message", data.optString("alert", null)); | |||
There was a problem hiding this comment.
@zo0r is there a reason why alert is used as the field and not message?
superandrew213
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android silent push notifications trigger alert with
Notification receivedmessage when app is in background.If there is no
messagesupplied then user should not be alerted with a default message. Otherwise it makes silent push notifications impossible on Android.At the moment every time a silent push notification is received (while app is in background) user receives an alert with
Notification receivedmessage.Fixes: #410