Add writeback option to metrics #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup.py: * Revert to original `perfmetrics` name * Keep the url as its original author
perfmetrics/__init__.py: * Add a writeback option so that the code that uses this metric decorator can the timing to be used internally. perfmetrics/tests/test_perfmetrics.py: * Add test to check on writeback option
neofob
pushed a commit
to neofob/perfmetrics
that referenced
this pull request
Oct 9, 2016
|
Thanks for the PR. I'm afraid it won't come close to applying without some work, though. It's probably better to start a fresh PR if this is still interesting. It's not clear to me, however, that this functionality really belongs here, or that there might not be a different way to implement it already (for example, by pushing a client onto the stack which saves the information locally and then calls the previous client). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to have the timing data to be written back to a list. Code that uses the decorator can have some info on the timing of the function.
This PR is based on the previous PR #1 by @replay.