Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict resolution doesn't need to read new pickle data from the database #38

Closed
jamadden opened this issue Jun 13, 2016 · 0 comments · Fixed by #67
Closed

Conflict resolution doesn't need to read new pickle data from the database #38

jamadden opened this issue Jun 13, 2016 · 0 comments · Fixed by #67
Milestone

Comments

@jamadden
Copy link
Member

This is because the new pickled data is already guaranteed to be in the local cache (an AutoTemporaryFile/SpooledTemporaryFile).

Upsides: less network IO (and at least in some DBs, the pickled data is base64 encoded, so lower overhead to decode). So theoretically it should be faster, especially if there are many conflicts.

Downsides: changing the conflict resolution code. On the other hand, this code path is pretty well tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant