Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx #95 #107

Merged
merged 3 commits into from
Jul 12, 2016
Merged

FIx #95 #107

merged 3 commits into from
Jul 12, 2016

Conversation

jamadden
Copy link
Member

This implements the new protocol for ZODB5 and ZODB>=4.4.2

I'm testing it against a specific ZODB branch because there was one more broken function in ZODB (both 4 and 5) that needs PRs merged (4 zopefoundation/ZODB#86) and released (4 and 5 zopefoundation/ZODB#85).

Very few changes outside the few small storage method changes, just a
few small changes to handle the different return types.

blob_packing and blob_transaction were synchronized with ZODB5 versions.

The tests will still fail pending new releases of ZODB 4 and 5.
@coveralls
Copy link

coveralls commented Jul 11, 2016

Coverage Status

Coverage increased (+0.002%) to 95.004% when pulling 28086b9 on new-protocol into 2df6b35 on master.

@jamadden
Copy link
Member Author

I'm strongly considering merging this, despite the test issue. It's just a test issue that will eventually get resolved. It doesn't affect the actual use of the code.

@coveralls
Copy link

coveralls commented Jul 12, 2016

Coverage Status

Coverage increased (+0.001%) to 95.003% when pulling 14c65a1 on new-protocol into 2df6b35 on master.

@jamadden jamadden merged commit f259659 into master Jul 12, 2016
@jamadden jamadden deleted the new-protocol branch January 4, 2017 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants