This repository has been archived by the owner on Jun 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-ma-zing Would it be possible to format the PHP to meet PSR? |
Sure can! With a couple of manual changes (namespaces, etc), automating it would probably be a good option. I can set things up to work with StyleCI or PHP CS Fixer.
@ThomasEdwards Preference between StyleCI or PHP CS Fixer? |
Not used either before! StyleCI looks like a good start – have signed up, hopefully will come through here. |
This fixes skipping to anchors
d0c6ab7
to
2b527bb
Compare
I applied code style fixes conforming to #4 |
zoe-edwards
approved these changes
Nov 10, 2019
patrickdaze
added a commit
to patrickdaze/bulma-search-chrome
that referenced
this pull request
Feb 17, 2020
https://github.com/thomasedwards/bulmasearch deployed the pull request zoe-edwards/bulmasearch#1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the contents of pages to the search index. The current search index only has page title.
PR improves search by:
While this PR might not be best the long term solution, I think it's more than sufficient for the time being. A better solution might be something like algolia/jekyll-algolia, or DocSearch.
PR Contents
Demo
Hosted: https://elegant-fermi-69a8e6.netlify.com/
Side-by-side comparison: Image