Support Markdown review format #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great stuff, I like the usecase of Eleventy Do you think we could add a basic test for this and add the new parameter to the documentation. An example of the output in the README would be good? |
|
@zoetrope69 Hi! Clarifying: were you asking for my assistance for either or both of those items (I think both are worthwhile)? I can help with the README part. I’m not as familiar with writing tests for node so would defer to you for that aspect (happy to learn, though) |
|
sure, i can write the tests if you update the readme |
|
thank you! |
|
@zoetrope69 Updated the README! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi—I’m working on a project (https://www.markllobrera.com/posts/letterboxd-to-markdown/) and I wanted the review to be in Markdown format, so I took a stab at implementing that. It uses a
reviewFormatparameter and if that is set tomarkdownI call a new methodgetReviewAsMarkdown(). There’s probably a more elegant way to do this, but happy to discuss my use case if you have questions!