Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the mast on my boat #45

Open
lotsmon opened this issue Dec 31, 2023 · 20 comments
Open

Moving the mast on my boat #45

lotsmon opened this issue Dec 31, 2023 · 20 comments
Labels
bug Something isn't working

Comments

@lotsmon
Copy link

lotsmon commented Dec 31, 2023

What happened?

image
When reloading assets, some objects on the boat change their location. Fixed by re-entering the world.

Steps to reproduce

  1. Set up the raft and install any mast.
  2. Move far enough away from the raft to unload raft assets.
  3. Return back to the raft.

Environment

OS:
- **OS**: Windows 11
- **Graphics**: DX11
Mods:
- denikson-BepInExPack_Valheim: 5.4.2202
- RandyKnapp-EpicLoot: 0.9.37
- ASharpPen-This_Goes_Here: 2.1.1
- gigvwvtt-EpicLootRus: 0.9.23
- MonsterLabZ-MonsterLabZ: 3.0.7
- Tekla-AutoRepair: 5.4.1602
- Advize-PlantEverything: 1.16.2
- Therzie-Warfare: 1.6.2
- GoldenJude-Blacksmiths_tools: 2.0.3
- GoldenJude-Judes_Equipment: 2.2.4
- HugotheDwarf-Shapekeys_and_More: 2.3.2
- HugotheDwarf-More_and_Modified_Player_Cloth_Colliders: 3.1.0
- HugotheDwarf-Hugos_Armory: 8.3.6
- virtuaCode-TrashItems: 1.2.7
- Nagir-MonsterLabZ_Russian_Translation_byNagir: 1.0.1
- Therzie-WarfareFireAndIce: 1.1.1
- Therzie-Armory: 1.1.6
- CW_Jesse-BetterNetworking_Valheim: 2.3.2
- ValheimModding-Jotunn: 2.15.2
- ValheimModding-HookGenPatcher: 0.0.4
- MathiasDecrock-PlanBuild: 0.14.7
- Advize-PlantEasily: 1.7.2
- CSG-CSG_Warfare_Monstrum_Epic_Loot_Support: 1.0.3
- RandyKnapp-EquipmentAndQuickSlots: 2.1.13
- Therzie-Monstrum: 1.3.2
- Therzie-MonstrumAshlands: 1.1.4
- Therzie-MonstrumDeepNorth: 1.1.1
- JereKuusela-Server_devcommands: 1.67.0
- JereKuusela-Upgrade_World: 1.46.0
- ComfyMods-Gizmo: 1.9.0
- lashiernexusmodport-Slope_Combat_Fix: 1.3.0
- Azumatt-FirstPersonMode: 1.2.7
- FixItFelix-AutoMapPins: 1.3.0
- FixItFelix-AutoMapPins_Krumpac_Reforge: 1.0.8
- MSchmoecker-VNEI: 0.14.0
- bonesbro-FloorsAreRoofs: 2.0.2
- Azumatt-Build_Camera_Custom_Hammers_Edition: 1.2.2
- OdinPlus-OdinsSteelworks: 0.1.23
- clevel-BeastsOfBurden: 1.0.4
- Balrond-balrond_shipyard: 1.2.6
- gdragon-ImmersiveCompass: 1.4.0
- Huntardys-EpicValheimsAdditions: 2.0.1
- aedenthorn_mods-AutoFuel: 1.2.0
- Azumatt-Official_BepInEx_ConfigurationManager: 18.2.0
- zolantris-ValheimRAFT: 1.6.10
@lotsmon lotsmon added the bug Something isn't working label Dec 31, 2023
@lotsmon
Copy link
Author

lotsmon commented Dec 31, 2023

the pattern has not yet been found, butmost often the mast, the steering wheel and sometimes the torch with the floor move off

@zolantris
Copy link
Owner

Hmm... there was a render optimization between >=1.6.8 so 1.6.10 has it.

It made the box issue completely go away (the create items logic was waiting per item per frame). So maybe there is more to it...maybe it needs to be kept but that could slow down the raft POP in effect when a zones load.

Some people were mentioning it taking 30seconds or more to render their raft box...I it was breaking items while it that initial pass.

@jose-carmona-villegas
Copy link

This is happening to me too, but I haven't found the steps to reproduce it yet.

@zolantris
Copy link
Owner

zolantris commented Dec 31, 2023

Try popping the raft in with a zone. IE fly away in dev fly mode (make sure the raft is gone completely, no far away object etc), then return. Is the mast still there? Are there any error logs?

@jose-carmona-villegas
Copy link

jose-carmona-villegas commented Jan 1, 2024

Tested what you suggested.

Flying away does not move the mast, but I got an error:
image

The error however has happened to me when I've left the raft and gone to explore (far enough so as not to see the raft anymore), spent some time away (enough to get the unload unused references message) and then come back to unload loot, only to find the messed up rigging and steering wheel.

EDIT:

I've been playing in my base and just parked my raft there and got busy defending the base and organizing loot, and it occured. No errors whatsoever in the whole session (I don't think the previous error applies). I don't think the unload of the assets is related either.

EDIT 2:

Thinking of it, I slept, and during sleeping the unloading of the unused assets occurs... that might be related.

@lotsmon
Copy link
Author

lotsmon commented Jan 1, 2024

After several restarts the problem stopped occurring. This was probably due to a version change or something like that.

@lotsmon
Copy link
Author

lotsmon commented Jan 1, 2024

I was wrong
image

This is probably due to the fact that I put the structure on the raft, and then moved away from the raft, thus unloading raft assets

This is not related to the installation of buildings on the raft.

Most often this happens if you teleport to a raft that stands at the other end of the map.

@lotsmon lotsmon changed the title Moving the mast in my boat Moving the mast on my boat Jan 1, 2024
@feifeid47
Copy link

同样遇到这个问题

复现步骤
当看不到船的时候,手动点击保存游戏,回到船所在的位置,船体就支离破碎了

@likemywaffels
Copy link

Hi, i have the same issue. From what it looks like that Vanilla and Mods pieces or items are getting separated after unloading. I will try to keep an eye on mods that do not get detached from vanilla part of the boat. But so far the Old Wooden Barrel and Large Wood Crate from Mod OdinsKingdom v1.2.17 by OdinPlus get detached. But OdinArchitect v1.2.7 by OdinPlus items and MissingPieces v2.0.5 by BentoG do not get detached from boat.
Tied moving away till boat despawns and got different outcomes:
Tried moving away and sleeping. Got detached.
Tried moving away and back. Nothing happens , boat loads all fine and intact.
Tried moving away and manually saving. Boat gets detached.
Only logging out and back in helps now.
Is there a way to create some kind of ward that prevents unloading of the raft at all?

@virtanum
Copy link

virtanum commented Jan 7, 2024

Anyone knows whether downgrading the mod fixes this problem? I'm tired of having to recreate the helm, masts, torches and cooking stations...

Also, this could be fixed by having these assets or the whole raft never "unload"... Is that an option?

@zolantris
Copy link
Owner

zolantris commented Jan 8, 2024

Requires a rewrite...also preventing unloads would have a resource impact on your machines (per raft zone loaded).

But it's possible. There's a few mods that allow preventing areas from unloading. Adding that might work well for now.

@virtanum
Copy link

@zolantris Do you remember any of those mods by name so I can look it up?

Also, what I though you could do is: Prevent unloading of certain objects by ID (base, sails, wheel - for a quick fix), or having them "attach" to their relative position to the base-raft, so that when everything else loads back, they'll be where they are supposed to be. Maybe write a method to "bind" these parts that get detached to the base, and we could do it manually.

I wish I could tackle that issue myself, but I can't on my own: I don't know C# well enough.
If you wanna voice-chat on discord, lemme know. I might help come up with a solution. :)

Thanks for your time and effort!

@jose-carmona-villegas
Copy link

There is a workaround to at least use the mod until the issue is fixed.
Simply logout and log back on and everything will return to its place.

@JasonLandbridge
Copy link

There is a workaround to at least use the mod until the issue is fixed. Simply logout and log back on and everything will return to its place.

Having to do this every 5 minutes is incredibly frustrating

@zolantris
Copy link
Owner

Having to do this every 5 minutes is incredibly frustrating

Have you tried 1.6.14? It should run the raft zdo update if you are hosting locally now as well.

@JasonLandbridge
Copy link

Have you tried 1.6.14? It should run the raft zdo update if you are hosting locally now as well.

I had to revert due to this issue: #53

Will try the new 1.6.14!

@jose-carmona-villegas
Copy link

There is a workaround to at least use the mod until the issue is fixed. Simply logout and log back on and everything will return to its place.

Having to do this every 5 minutes is incredibly frustrating

I did not mean it as a permanent workaround, I just meant it as a way to give @zolantris some breathing room while it gets fixed.

@zolantris
Copy link
Owner

zolantris commented Jan 22, 2024

1.6.14 should fix most of these issues. (other people have reported)

@lotsmon
Copy link
Author

lotsmon commented Jan 26, 2024

1.6.14 should fix most of these issues. (other people have reported)

My problem is solved.

@JasonLandbridge
Copy link

@zolantris I am on the latest version 1.6.14 and it did fix it initially but it somehow got worse as I played more.

Before the update only a few things would be out of place as OP described, but now the entire ship dissappears leaving behind a few things. The workaround still works though by logging out and in.

Checking the logs didn't yield anything. I can try to record a video if that would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants